netdev - Re: [PATCH net-next v6 0/4] net/sched: Introduce tc connection tracking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <67d3c788-c79b-d923-3bc5-9e1ee067e324@mellanox.com>
Date:   Thu, 11 Jul 2019 07:12:44 +0000
From:   Paul Blakey <paulb@...lanox.com>
To:     David Miller <davem@...emloft.net>
CC:     Jiri Pirko <jiri@...lanox.com>, Roi Dayan <roid@...lanox.com>,
        Yossi Kuperman <yossiku@...lanox.com>,
        Oz Shlomo <ozsh@...lanox.com>,
        "marcelo.leitner@...il.com" <marcelo.leitner@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "aconole@...hat.com" <aconole@...hat.com>,
        "wangzhike@...com" <wangzhike@...com>,
        Rony Efraim <ronye@...lanox.com>,
        "nst-kernel@...hat.com" <nst-kernel@...hat.com>,
        "john.hurley@...ronome.com" <john.hurley@...ronome.com>,
        "simon.horman@...ronome.com" <simon.horman@...ronome.com>,
        "jpettit@....org" <jpettit@....org>
Subject: Re: [PATCH net-next v6 0/4] net/sched: Introduce tc connection
 tracking


On 7/9/2019 10:14 PM, David Miller wrote:
> From: Paul Blakey <paulb@...lanox.com>
> Date: Tue,  9 Jul 2019 10:30:47 +0300
>
>> This patch series add connection tracking capabilities in tc sw datapath.
>> It does so via a new tc action, called act_ct, and new tc flower classifier matching
>> on conntrack state, mark and label.
>   ...
>
> Ok, I applied this, but two things:
>
> 1) You owe Cong Wang an explanation, a real detailed one, about the L2
>     vs L3 design of this feature.  I did not see you address his feedback,
>     but if you did I apologize.
>
> 2) Because the MPLS changes went in first, TCA_ID_CT ended up in a
>     different spot in the enumeration and therefore the value is
>     different.
>
> Thanks.



Thanks!

Re 1, I provided one in "Re: [PATCH net-next v2 0/4] net/sched: 
Introduce tc connection tracking", hope that's enough.