netdev - Re: [PATCH bpf-next] libbpf: fix ptr to u64 conversion warning on 32-bit platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ea3c62c8-214d-1ad9-9235-7d52d7c36143@iogearbox.net>
Date:   Fri, 12 Jul 2019 15:06:37 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Matt Hart <matthew.hart@...aro.org>, Yonghong Song <yhs@...com>
Cc:     Andrii Nakryiko <andriin@...com>,
        "andrii.nakryiko@...il.com" <andrii.nakryiko@...il.com>,
        Alexei Starovoitov <ast@...com>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Kernel Team <Kernel-team@...com>
Subject: Re: [PATCH bpf-next] libbpf: fix ptr to u64 conversion warning on
 32-bit platforms

On 07/12/2019 02:56 PM, Matt Hart wrote:
> On Tue, 9 Jul 2019 at 05:30, Yonghong Song <yhs@...com> wrote:
>> On 7/8/19 9:00 PM, Andrii Nakryiko wrote:
>>> On 32-bit platforms compiler complains about conversion:
>>>
>>> libbpf.c: In function ‘perf_event_open_probe’:
>>> libbpf.c:4112:17: error: cast from pointer to integer of different
>>> size [-Werror=pointer-to-int-cast]
>>>    attr.config1 = (uint64_t)(void *)name; /* kprobe_func or uprobe_path */
>>>                   ^
>>>
>>> Reported-by: Matt Hart <matthew.hart@...aro.org>
>>> Fixes: b26500274767 ("libbpf: add kprobe/uprobe attach API")
>>> Tested-by: Matt Hart <matthew.hart@...aro.org>
>>> Signed-off-by: Andrii Nakryiko <andriin@...com>
>>
>> Acked-by: Yonghong Song <yhs@...com>
> 
> How do we get this merged? I see the build failure has now propagated
> up to mainline :(

I just applied the fix to bpf tree, will go its usual route to mainline.