netdev - Re: [PATCH] net: fec: generate warning when using deprecated phy reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGngYiULAjXwwxmUyHxEXhv1WzSeE_wE3idOLSnD5eEaZg3xDw@mail.gmail.com>
Date:   Thu, 18 Jul 2019 13:21:36 -0400
From:   Sven Van Asbroeck <thesven73@...il.com>
To:     Fabio Estevam <festevam@...il.com>
Cc:     Lucas Stach <l.stach@...gutronix.de>,
        Fugang Duan <fugang.duan@....com>,
        "David S . Miller" <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: fec: generate warning when using deprecated phy reset

Lucas, Fabio,

On Thu, Jul 18, 2019 at 12:52 PM Fabio Estevam <festevam@...il.com> wrote:
>
> > Not really a fan of this. This will cause existing DTs, which are
> > provided by the firmware in an ideal world and may not change at the
> > same rate as the kernel, to generate a warning with new kernels. Not
> > really helpful from the user experience point of view.
>
> I agree. I don't think this warning is useful.

Few users watch the dmesg log, But I totally see your point.

The problem I'm trying to address here is this: when I want to
reset the fec phy, I go look at existing devicetrees. Nearly
all of them use phy-reset-gpios, so that's what I'll use. But,
when I try to upstream the patch, the maintainer will tell me:
"no, that is deprecated, use this other method".

Is there a good solution you can think of which would point
the unwary developer to the correct phy reset method?

See my previous thread here:
https://lkml.org/lkml/2019/7/15/1764