netdev - Re: [PATCH net-next v2] net/mlx5e: xsk: dynamically allocate mlx5e_channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190723.133959.1151778509619674259.davem@davemloft.net>
Date:   Tue, 23 Jul 2019 13:39:59 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     maximmi@...lanox.com
Cc:     arnd@...db.de, ast@...nel.org, daniel@...earbox.net,
        bpf@...r.kernel.org, netdev@...r.kernel.org, saeedm@...lanox.com,
        leon@...nel.org, jakub.kicinski@...ronome.com, hawk@...nel.org,
        john.fastabend@...il.com, tariqt@...lanox.com
Subject: Re: [PATCH net-next v2] net/mlx5e: xsk: dynamically allocate
 mlx5e_channel_param

From: Maxim Mikityanskiy <maximmi@...lanox.com>
Date: Tue, 23 Jul 2019 12:02:26 +0000

> From: Arnd Bergmann <arnd@...db.de>
> 
> The structure is too large to put on the stack, resulting in a
> warning on 32-bit ARM:
> 
> drivers/net/ethernet/mellanox/mlx5/core/en/xsk/setup.c:59:5: error: stack frame size of 1344 bytes in function
>       'mlx5e_open_xsk' [-Werror,-Wframe-larger-than=]
> 
> Use kvzalloc() instead.
> 
> Fixes: a038e9794541 ("net/mlx5e: Add XSK zero-copy support")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: Maxim Mikityanskiy <maximmi@...lanox.com>
> ---
> v2 changes: use kvzalloc/kvfree and fix a memory leak.

I'll apply this directly to net-next.

Thanks Maxim.