netdev - Re: [PATCH v3 4/7] net: Reorder the contents of skb_frag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2b45504e005f88a033405225b04fba0b5dcf2e92.camel@mellanox.com>
Date:   Tue, 23 Jul 2019 22:29:06 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     "willy@...radead.org" <willy@...radead.org>,
        "davem@...emloft.net" <davem@...emloft.net>
CC:     "hch@....de" <hch@....de>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH v3 4/7] net: Reorder the contents of skb_frag_t

On Fri, 2019-07-12 at 06:43 -0700, Matthew Wilcox wrote:
> From: "Matthew Wilcox (Oracle)" <willy@...radead.org>
> 
> Match the layout of bio_vec.
> 
> Signed-off-by: Matthew Wilcox (Oracle) <willy@...radead.org>
> ---
>  include/linux/skbuff.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
> index 7910935410e6..b9dc8b4f24b1 100644
> --- a/include/linux/skbuff.h
> +++ b/include/linux/skbuff.h
> @@ -314,8 +314,8 @@ struct skb_frag_struct {
>  	struct {
>  		struct page *p;
>  	} page;
> -	__u32 page_offset;
>  	__u32 size;
> +	__u32 page_offset;
>  };
>  

Why do you need this patch? this struct is going to be removed
downstream eventually ..

>  /**