netdev - Re: [PATCH v3 6/7] net: Rename skb_frag_t size to bv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <267e43638c85447a5251ce9ca33356da4a8aa3f3.camel@mellanox.com>
Date:   Tue, 23 Jul 2019 22:33:59 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     "willy@...radead.org" <willy@...radead.org>,
        "davem@...emloft.net" <davem@...emloft.net>
CC:     "hch@....de" <hch@....de>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH v3 6/7] net: Rename skb_frag_t size to bv_len

On Fri, 2019-07-12 at 06:43 -0700, Matthew Wilcox wrote:
> From: "Matthew Wilcox (Oracle)" <willy@...radead.org>
> 
> Improved compatibility with bvec
> 
> Signed-off-by: Matthew Wilcox (Oracle) <willy@...radead.org>
> ---
>  include/linux/skbuff.h | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
> index 8076e2ba8349..e849e411d1f3 100644
> --- a/include/linux/skbuff.h
> +++ b/include/linux/skbuff.h
> @@ -312,7 +312,7 @@ typedef struct skb_frag_struct skb_frag_t;
>  
>  struct skb_frag_struct {
>  	struct page *bv_page;
> -	__u32 size;
> +	unsigned int bv_len;
>  	__u32 page_offset;

Why do you keep page_offset name and type as is ? it will make the last
patch much cleaner if you change it to "unsigned int bv_offset".
unsigned int and __u32 on both 32bit and 64bit are the same aren't they
?

>  };
>  
> @@ -322,7 +322,7 @@ struct skb_frag_struct {
>   */
>  static inline unsigned int skb_frag_size(const skb_frag_t *frag)
>  {
> -	return frag->size;
> +	return frag->bv_len;
>  }
>  
>  /**
> @@ -332,7 +332,7 @@ static inline unsigned int skb_frag_size(const
> skb_frag_t *frag)
>   */
>  static inline void skb_frag_size_set(skb_frag_t *frag, unsigned int
> size)
>  {
> -	frag->size = size;
> +	frag->bv_len = size;
>  }
>  
>  /**
> @@ -342,7 +342,7 @@ static inline void skb_frag_size_set(skb_frag_t
> *frag, unsigned int size)
>   */
>  static inline void skb_frag_size_add(skb_frag_t *frag, int delta)
>  {
> -	frag->size += delta;
> +	frag->bv_len += delta;
>  }
>  
>  /**
> @@ -352,7 +352,7 @@ static inline void skb_frag_size_add(skb_frag_t
> *frag, int delta)
>   */
>  static inline void skb_frag_size_sub(skb_frag_t *frag, int delta)
>  {
> -	frag->size -= delta;
> +	frag->bv_len -= delta;
>  }
>  
>  /**