netdev - Re: [PATCH v4 net-next 05/19] ionic: Add interrupts and doorbells

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3ca116c9-b19b-2e48-ded9-83f949a0ccd8@pensando.io>
Date:   Tue, 23 Jul 2019 15:50:29 -0700
From:   Shannon Nelson <snelson@...sando.io>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH v4 net-next 05/19] ionic: Add interrupts and doorbells

On 7/23/19 2:24 PM, David Miller wrote:
> From: Shannon Nelson <snelson@...sando.io>
> Date: Mon, 22 Jul 2019 14:40:09 -0700
>
>> The ionic interrupt model is based on interrupt control blocks
>> accessed through the PCI BAR.  Doorbell registers are used by
>> the driver to signal to the NIC that requests are waiting on
>> the message queues.  Interrupts are used by the NIC to signal
>> to the driver that answers are waiting on the completion queues.
>>
>> Signed-off-by: Shannon Nelson <snelson@...sando.io>
> After applying this patch we get a warning:
>
> drivers/net/ethernet/pensando/ionic/ionic_lif.c:33:13: warning: ‘ionic_intr_free’ defined but not used [-Wunused-function]
>   static void ionic_intr_free(struct lif *lif, int index)
>               ^~~~~~~~~~~~~~~
> drivers/net/ethernet/pensando/ionic/ionic_lif.c:15:12: warning: ‘ionic_intr_alloc’ defined but not used [-Wunused-function]
>   static int ionic_intr_alloc(struct lif *lif, struct intr *intr)
>              ^~~~~~~~~~~~~~~~

Yes, and they get used in the next patch.  This is so I can keep similar 
bits of functionality together in one patch and to keep the next patch a 
little smaller.

> Also:
>
>> +	lif->dbid_inuse = kzalloc(BITS_TO_LONGS(lif->dbid_count) * sizeof(long),
>> +				  GFP_KERNEL);
> You can use bitmap_alloc() and friends from linux/bitmap.h for this kind of stuff.

Sure.
sln