netdev - Re: [PATCH v4 net-next 06/19] ionic: Add basic adminq support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <788e8ca5-a281-60a2-5260-8f71e24bf99d@pensando.io>
Date:   Tue, 23 Jul 2019 15:50:37 -0700
From:   Shannon Nelson <snelson@...sando.io>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH v4 net-next 06/19] ionic: Add basic adminq support

On 7/23/19 2:27 PM, David Miller wrote:
> From: Shannon Nelson <snelson@...sando.io>
> Date: Mon, 22 Jul 2019 14:40:10 -0700
>
>> +struct queue {
>   ...
>> +struct cq {
>   ...
>> +struct napi_stats {
>   ...
>> +struct q_stats {
>   ...
>> +struct qcq {
> Using names like these and "dev_queue" are just asking for conflicts with the
> global datastructure namespace both now and in the future.
>
> Please put ionic_ or similar as a prefix to these data structure names.
>
> Thank you.

Sure
sln