netdev - Re: [PATCH v3 6/7] net: Rename skb_frag_t size to bv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190724013055.GR363@bombadil.infradead.org>
Date:   Tue, 23 Jul 2019 18:30:55 -0700
From:   Matthew Wilcox <willy@...radead.org>
To:     Saeed Mahameed <saeedm@...lanox.com>
Cc:     "davem@...emloft.net" <davem@...emloft.net>,
        "hch@....de" <hch@....de>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH v3 6/7] net: Rename skb_frag_t size to bv_len

On Tue, Jul 23, 2019 at 10:33:59PM +0000, Saeed Mahameed wrote:
> >  struct skb_frag_struct {
> >  	struct page *bv_page;
> > -	__u32 size;
> > +	unsigned int bv_len;
> >  	__u32 page_offset;
> 
> Why do you keep page_offset name and type as is ? it will make the last
> patch much cleaner if you change it to "unsigned int bv_offset".

We don't have an accessor for page_offset, so there are about 280
occurrences of '>page_offset' in drivers/net/

Feel free to be the hero who does that cleanup.