netdev - Re: [PATCH v3 6/7] net: Rename skb_frag_t size to bv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <60387845de777559c0067fcf892966f7ec68010b.camel@mellanox.com>
Date:   Wed, 24 Jul 2019 17:58:55 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     "willy@...radead.org" <willy@...radead.org>
CC:     "hch@....de" <hch@....de>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH v3 6/7] net: Rename skb_frag_t size to bv_len

On Tue, 2019-07-23 at 18:30 -0700, Matthew Wilcox wrote:
> On Tue, Jul 23, 2019 at 10:33:59PM +0000, Saeed Mahameed wrote:
> > >  struct skb_frag_struct {
> > >  	struct page *bv_page;
> > > -	__u32 size;
> > > +	unsigned int bv_len;
> > >  	__u32 page_offset;
> > 
> > Why do you keep page_offset name and type as is ? it will make the
> > last
> > patch much cleaner if you change it to "unsigned int bv_offset".
> 
> We don't have an accessor for page_offset, so there are about 280
> occurrences of '>page_offset' in drivers/net/
> 

I understand but why not chaining the type to "unsigned int" at least
to avoid confusion ? 

> Feel free to be the hero who does that cleanup.