lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 27 Jul 2019 14:00:29 -0700 (PDT) From: David Miller <davem@...emloft.net> To: skalluru@...vell.com Cc: netdev@...r.kernel.org, mkalderon@...vell.com, aelior@...vell.com Subject: Re: [PATCH net-next v2 1/2] qed: Add API for configuring NVM attributes. From: Sudarsana Reddy Kalluru <skalluru@...vell.com> Date: Fri, 26 Jul 2019 08:52:14 -0700 > +int qed_mcp_nvm_set_cfg(struct qed_hwfn *p_hwfn, struct qed_ptt *p_ptt, > + u16 option_id, u8 entity_id, u16 flags, u8 *p_buf, > + u32 len) > +{ > + u32 mb_param = 0, resp, param; > + int rc; ... > + rc = qed_mcp_nvm_wr_cmd(p_hwfn, p_ptt, > + DRV_MSG_CODE_SET_NVM_CFG_OPTION, > + mb_param, &resp, ¶m, len, (u32 *)p_buf); > + > + return rc; 'rc' is completely unnecessary, please just return the function result directly. Thank you.
Powered by blists - more mailing lists