lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 28 Jul 2019 01:39:15 +0000 From: Sudarsana Reddy Kalluru <skalluru@...vell.com> To: David Miller <davem@...emloft.net> CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Michal Kalderon <mkalderon@...vell.com>, Ariel Elior <aelior@...vell.com> Subject: RE: [PATCH net-next v2 1/2] qed: Add API for configuring NVM attributes. > -----Original Message----- > From: netdev-owner@...r.kernel.org <netdev-owner@...r.kernel.org> On > Behalf Of David Miller > Sent: Sunday, July 28, 2019 2:30 AM > To: Sudarsana Reddy Kalluru <skalluru@...vell.com> > Cc: netdev@...r.kernel.org; Michal Kalderon <mkalderon@...vell.com>; > Ariel Elior <aelior@...vell.com> > Subject: Re: [PATCH net-next v2 1/2] qed: Add API for configuring NVM > attributes. > > From: Sudarsana Reddy Kalluru <skalluru@...vell.com> > Date: Fri, 26 Jul 2019 08:52:14 -0700 > > > +int qed_mcp_nvm_set_cfg(struct qed_hwfn *p_hwfn, struct qed_ptt > *p_ptt, > > + u16 option_id, u8 entity_id, u16 flags, u8 *p_buf, > > + u32 len) > > +{ > > + u32 mb_param = 0, resp, param; > > + int rc; > ... > > + rc = qed_mcp_nvm_wr_cmd(p_hwfn, p_ptt, > > + DRV_MSG_CODE_SET_NVM_CFG_OPTION, > > + mb_param, &resp, ¶m, len, (u32 > *)p_buf); > > + > > + return rc; > > 'rc' is completely unnecessary, please just return the function result directly. > > Thank you. Thanks for your comments. Will send the updated patch.
Powered by blists - more mailing lists