netdev - Re: [PATCH net v2] mvpp2: refactor MTU change code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190729.110106.1654712144874525336.davem@davemloft.net>
Date:   Mon, 29 Jul 2019 11:01:06 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     mcroce@...hat.com
Cc:     netdev@...r.kernel.org, antoine.tenart@...tlin.com,
        maxime.chevallier@...tlin.com, mw@...ihalf.com,
        stefanc@...vell.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v2] mvpp2: refactor MTU change code

From: Matteo Croce <mcroce@...hat.com>
Date: Sun, 28 Jul 2019 02:46:45 +0200

> The MTU change code can call napi_disable() with the device already down,
> leading to a deadlock. Also, lot of code is duplicated unnecessarily.
> 
> Rework mvpp2_change_mtu() to avoid the deadlock and remove duplicated code.
> 
> Fixes: 3f518509dedc ("ethernet: Add new driver for Marvell Armada 375 network unit")
> Signed-off-by: Matteo Croce <mcroce@...hat.com>

Applied and queued up for -stable, thanks.