netdev - Re: [PATCH net-next v3 2/2] qed: Add driver API for flashing the config attributes.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190729.110342.703558396264560468.davem@davemloft.net>
Date:   Mon, 29 Jul 2019 11:03:42 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     skalluru@...vell.com
Cc:     netdev@...r.kernel.org, mkalderon@...vell.com, aelior@...vell.com
Subject: Re: [PATCH net-next v3 2/2] qed: Add driver API for flashing the
 config attributes.

From: Sudarsana Reddy Kalluru <skalluru@...vell.com>
Date: Sat, 27 Jul 2019 18:55:49 -0700

> @@ -2268,6 +2330,9 @@ static int qed_nvm_flash(struct qed_dev *cdev, const char *name)
>  			rc = qed_nvm_flash_image_access(cdev, &data,
>  							&check_resp);
>  			break;
> +		case QED_NVM_FLASH_CMD_NVM_CFG_ID:
> +			rc = qed_nvm_flash_cfg_write(cdev, &data);
> +			break;
>  		default:
>  			DP_ERR(cdev, "Unknown command %08x\n", cmd_type);

I don't see how any existing portable interface can cause this new code to
actually be used.

You have to explain this to me.