netdev - Re: [PATCH net-next] r8169: make use of xmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190729.110541.288160530723382059.davem@davemloft.net>
Date:   Mon, 29 Jul 2019 11:05:41 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     nic_swsd@...ltek.com, netdev@...r.kernel.org, linux@...elenboom.it,
        edumazet@...gle.com
Subject: Re: [PATCH net-next] r8169: make use of xmit_more

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Sun, 28 Jul 2019 11:25:19 +0200

> There was a previous attempt to use xmit_more, but the change had to be
> reverted because under load sometimes a transmit timeout occurred [0].
> Maybe this was caused by a missing memory barrier, the new attempt
> keeps the memory barrier before the call to netif_stop_queue like it
> is used by the driver as of today. The new attempt also changes the
> order of some calls as suggested by Eric.
> 
> [0] https://lkml.org/lkml/2019/2/10/39
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Applied.