netdev - Re: [PATCH v4 net-next 15/19] ionic: Add netdev-event handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <087179c7-4cc4-f77b-1d6e-915c6c4877c6@pensando.io>
Date:   Tue, 30 Jul 2019 18:10:25 -0700
From:   Shannon Nelson <snelson@...sando.io>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH v4 net-next 15/19] ionic: Add netdev-event handling

On 7/30/19 4:39 PM, Stephen Hemminger wrote:
> On Mon, 22 Jul 2019 14:40:19 -0700
> Shannon Nelson <snelson@...sando.io> wrote:
>
>> +
>> +static void ionic_lif_set_netdev_info(struct lif *lif)
>> +{
>> +	struct ionic_admin_ctx ctx = {
>> +		.work = COMPLETION_INITIALIZER_ONSTACK(ctx.work),
>> +		.cmd.lif_setattr = {
>> +			.opcode = CMD_OPCODE_LIF_SETATTR,
>> +			.index = cpu_to_le16(lif->index),
>> +			.attr = IONIC_LIF_ATTR_NAME,
>> +		},
>> +	};
>> +
>> +	strlcpy(ctx.cmd.lif_setattr.name, lif->netdev->name,
>> +		sizeof(ctx.cmd.lif_setattr.name));
>> +
>> +	dev_info(lif->ionic->dev, "NETDEV_CHANGENAME %s %s\n",
>> +		 lif->name, ctx.cmd.lif_setattr.name);
>> +
> There is already a kernel message for this. Repeating the same thing in the
> driver is redundant.

True, except for the lif name information.  But since that really is 
debugging information, and I was getting tired of seeing those redundant 
messages, I was planning to remove them soon anyway. Thanks for the 
extra nudge.

sln