netdev - Re: [PATCH v4 net-next 18/19] ionic: Add coalesce and other features

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ee9e32ca-14ce-9893-8257-0e7eac0c42d3@pensando.io>
Date:   Fri, 2 Aug 2019 14:48:47 -0700
From:   Shannon Nelson <snelson@...sando.io>
To:     Saeed Mahameed <saeedm@...lanox.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>
Subject: Re: [PATCH v4 net-next 18/19] ionic: Add coalesce and other features

On 7/25/19 5:13 PM, Saeed Mahameed wrote:
> On Mon, 2019-07-22 at 14:40 -0700, Shannon Nelson wrote:

>> +static void ionic_tx_timeout_work(struct work_struct *ws)
>> +{
>> +	struct lif *lif = container_of(ws, struct lif,
>> tx_timeout_work);
>> +
>> +	netdev_info(lif->netdev, "Tx Timeout recovery\n");
>> +	ionic_reset_queues(lif);
> missing rtnl_lock ?
>
>> +}
>> +
>>   static void ionic_tx_timeout(struct net_device *netdev)
>>   {
>> -	netdev_info(netdev, "%s: stubbed\n", __func__);
>> +	struct lif *lif = netdev_priv(netdev);
>> +
>> +	schedule_work(&lif->tx_timeout_work);
>>   }
> missing cancel work ? be careful when combined with the rtnl_lockthough ..
>
>

Yep, good catch on both.  I'll take care of those.

sln