netdev - Re: [PATCH net-next] be2net: disable bh with spin_lock in be_process

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOJe8K2TE-g=MwEHH82e1UryANymFbtgE60Ltpf9pwaHLVDSfA@mail.gmail.com>
Date:   Wed, 31 Jul 2019 13:54:51 +0300
From:   Denis Kirjanov <kda@...ux-powerpc.org>
To:     Willem de Bruijn <willemdebruijn.kernel@...il.com>
Cc:     sathya.perla@...adcom.com, ajit.khaparde@...adcom.com,
        sriharsha.basavapatna@...adcom.com,
        Network Development <netdev@...r.kernel.org>,
        Denis Kirjanov <kdav@...ux-powerpc.org>
Subject: Re: [PATCH net-next] be2net: disable bh with spin_lock in be_process_mcc

On 7/30/19, Willem de Bruijn <willemdebruijn.kernel@...il.com> wrote:
> On Tue, Jul 30, 2019 at 7:33 AM Denis Kirjanov <kda@...ux-powerpc.org>
> wrote:
>>
>> Signed-off-by: Denis Kirjanov <kdav@...ux-powerpc.org>
>
> This is a partial revert of the previous change to these lines in 2012
> in commit 072a9c486004 ("netpoll: revert 6bdb7fe3104 and fix be_poll()
> instead").
>
> The commit message is empty. Can you give some context as to why this
> is needed and correct?

The idea was just to make some cleanup. Now I've checked that be_process_mcc
is invoked in 3 different places and always with BHs disabled except
the be_poll function but since it's invoked from softirq with BHs
disabled it won't hurt.


>