netdev - Re: [net] ixgbe: fix possible deadlock in ixgbe_service

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190806.145104.1044990165298646882.davem@davemloft.net>
Date:   Tue, 06 Aug 2019 14:51:04 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jeffrey.t.kirsher@...el.com
Cc:     ap420073@...il.com, netdev@...r.kernel.org, nhorman@...hat.com,
        sassmann@...hat.com, andrewx.bowers@...el.com
Subject: Re: [net] ixgbe: fix possible deadlock in ixgbe_service_task()

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Mon,  5 Aug 2019 13:04:03 -0700

> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> index cbaf712d6529..3386e752e458 100644
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> @@ -7898,9 +7898,7 @@ static void ixgbe_service_task(struct work_struct *work)
>  	}
>  	if (ixgbe_check_fw_error(adapter)) {
>  		if (!test_bit(__IXGBE_DOWN, &adapter->state)) {
> -			rtnl_lock();
>  			unregister_netdev(adapter->netdev);
> -			rtnl_unlock();
>  		}

Please remove the (now unnecessary) curly braces for this basic block.

Thank you.