netdev - Re: [net] ixgbe: fix possible deadlock in ixgbe_service

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMArcTXWBHUpy+p18UJ6RZm2W=vhnLRezste=kHSSv=dyd0kBA@mail.gmail.com>
Date:   Wed, 7 Aug 2019 15:08:07 +0900
From:   Taehee Yoo <ap420073@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     jeffrey.t.kirsher@...el.com, Netdev <netdev@...r.kernel.org>,
        nhorman@...hat.com, sassmann@...hat.com, andrewx.bowers@...el.com
Subject: Re: [net] ixgbe: fix possible deadlock in ixgbe_service_task()

On Wed, 7 Aug 2019 at 08:36, David Miller <davem@...emloft.net> wrote:
>

Hi David
Thank you for the review!

> From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> Date: Mon,  5 Aug 2019 13:04:03 -0700
>
> > diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> > index cbaf712d6529..3386e752e458 100644
> > --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> > +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> > @@ -7898,9 +7898,7 @@ static void ixgbe_service_task(struct work_struct *work)
> >       }
> >       if (ixgbe_check_fw_error(adapter)) {
> >               if (!test_bit(__IXGBE_DOWN, &adapter->state)) {
> > -                     rtnl_lock();
> >                       unregister_netdev(adapter->netdev);
> > -                     rtnl_unlock();
> >               }
>
> Please remove the (now unnecessary) curly braces for this basic block.
>

I will send a v2 patch.
Thank you!

> Thank you.