netdev - Re: [PATCH net] netlink: Fix nlmsg_parse as a wrapper for strict message parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dec209a4-b72a-86c3-d8d5-a080e1249886@gmail.com>
Date:   Tue, 13 Aug 2019 13:31:34 +0200
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     David Ahern <dsahern@...nel.org>, davem@...emloft.net
Cc:     netdev@...r.kernel.org, johannes.berg@...el.com,
        edumazet@...gle.com, David Ahern <dsahern@...il.com>
Subject: Re: [PATCH net] netlink: Fix nlmsg_parse as a wrapper for strict
 message parsing



On 8/12/19 10:07 PM, David Ahern wrote:
> From: David Ahern <dsahern@...il.com>
> 
> Eric reported a syzbot warning:
> 
> 
> The root cause is nlmsg_parse calling __nla_parse which means the
> header struct size is not checked.
> 
> nlmsg_parse should be a wrapper around __nlmsg_parse with
> NL_VALIDATE_STRICT for the validate argument very much like
> nlmsg_parse_deprecated is for NL_VALIDATE_LIBERAL.
> 
> Fixes: 3de6440354465 ("netlink: re-add parse/validate functions in strict mode")
> Reported-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: syzbot <syzkaller@...glegroups.com>
> Signed-off-by: David Ahern <dsahern@...il.com>
> ---

Reviewed-by: Eric Dumazet <edumazet@...gle.com>

Thanks !