netdev - Re: [PATCH net-next v2 11/14] netdevsim: Add devlink-trap support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190814165957.0e626f57@cakuba.netronome.com>
Date:   Wed, 14 Aug 2019 16:59:57 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Ido Schimmel <idosch@...sch.org>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, nhorman@...driver.com,
        jiri@...lanox.com, toke@...hat.com, dsahern@...il.com,
        roopa@...ulusnetworks.com, nikolay@...ulusnetworks.com,
        andy@...yhouse.net, f.fainelli@...il.com, andrew@...n.ch,
        vivien.didelot@...il.com, mlxsw@...lanox.com,
        Ido Schimmel <idosch@...lanox.com>
Subject: Re: [PATCH net-next v2 11/14] netdevsim: Add devlink-trap support

On Tue, 13 Aug 2019 10:53:57 +0300, Ido Schimmel wrote:
> diff --git a/drivers/net/netdevsim/dev.c b/drivers/net/netdevsim/dev.c
> index 08ca59fc189b..2758d95c8d18 100644
> --- a/drivers/net/netdevsim/dev.c
> +++ b/drivers/net/netdevsim/dev.c
> @@ -17,11 +17,21 @@
>  
>  #include <linux/debugfs.h>
>  #include <linux/device.h>
> +#include <linux/etherdevice.h>
> +#include <linux/inet.h>
> +#include <linux/jiffies.h>
> +#include <linux/kernel.h>
>  #include <linux/list.h>
>  #include <linux/mutex.h>
>  #include <linux/random.h>
> +#include <linux/workqueue.h>
> +#include <linux/random.h>
>  #include <linux/rtnetlink.h>
>  #include <net/devlink.h>
> +#include <net/ip.h>
> +#include <uapi/linux/devlink.h>
> +#include <uapi/linux/ip.h>
> +#include <uapi/linux/udp.h>

Please keep includes ordered alphabetically. You're adding
linux/random.h second time.

>  #include "netdevsim.h"

> +static void nsim_dev_trap_report(struct nsim_dev_port *nsim_dev_port)
> +{
> +	struct nsim_dev *nsim_dev = nsim_dev_port->ns->nsim_dev;
> +	struct nsim_trap_data *nsim_trap_data = nsim_dev->trap_data;
> +	struct devlink *devlink = priv_to_devlink(nsim_dev);
> +	int i;

reverse christmas tree, please