netdev - Re: [PATCH] net: hns: hns_enet: Add of_node_put in hns_nic_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <857ab233-b983-bb99-ae0e-107560d67af1@huawei.com>
Date:   Thu, 15 Aug 2019 17:59:17 +0800
From:   Yonglong Liu <liuyonglong@...wei.com>
To:     Nishka Dasgupta <nishkadg.linux@...il.com>,
        <yisen.zhuang@...wei.com>, <salil.mehta@...wei.com>,
        <davem@...emloft.net>, <netdev@...r.kernel.org>
Subject: Re: [PATCH] net: hns: hns_enet: Add of_node_put in
 hns_nic_dev_probe()



On 2019/8/15 14:28, Nishka Dasgupta wrote:
> The local variable ae_node in function hns_nic_dev_probe takes the
> return value of of_parse_phandle, which gets a node but does not put it.
> This may cause a memory leak. Hence put ae_node after the last time it
> is invoked.
> Issue found with Coccinelle.
> 
> Signed-off-by: Nishka Dasgupta <nishkadg.linux@...il.com>
> ---
>  drivers/net/ethernet/hisilicon/hns/hns_enet.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/hisilicon/hns/hns_enet.c b/drivers/net/ethernet/hisilicon/hns/hns_enet.c
> index 2235dd55fab2..b26e84929e1e 100644
> --- a/drivers/net/ethernet/hisilicon/hns/hns_enet.c
> +++ b/drivers/net/ethernet/hisilicon/hns/hns_enet.c
> @@ -2309,6 +2309,7 @@ static int hns_nic_dev_probe(struct platform_device *pdev)
>  			goto out_read_prop_fail;
>  		}
>  		priv->fwnode = &ae_node->fwnode;
> +		of_node_put(ae_node);
>  	} else if (is_acpi_node(dev->fwnode)) {
>  		struct fwnode_reference_args args;
>  
> 

Hi, Nishka:
This patch is wrong, we put the node in hns_nic_dev_remove().

The following patch had solved this problem:
263c6d75f9a5 (net: hns: Fix for missing of_node_put() after of_parse_phandle())