netdev - Re: [PATCH bpf-next] libbpf: relicense bpf_helpers.h and bpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 16 Aug 2019 14:10:01 +0200
From:   Jesper Dangaard Brouer <brouer@...hat.com>
To:     Andrii Nakryiko <andriin@...com>
Cc:     brouer@...hat.com, <bpf@...r.kernel.org>, <netdev@...r.kernel.org>,
        <andrii.nakryiko@...il.com>, <kernel-team@...com>,
        Michael Holzheu <holzheu@...ux.vnet.ibm.com>,
        "Naveen N . Rao" <naveen.n.rao@...ux.vnet.ibm.com>,
        "David S . Miller" <davem@...emloft.net>,
        Michal Rostecki <mrostecki@...nsuse.org>,
        John Fastabend <john.fastabend@...il.com>,
        Sargun Dhillon <sargun@...gun.me>
Subject: Re: [PATCH bpf-next] libbpf: relicense bpf_helpers.h and
 bpf_endian.h

On Thu, 15 Aug 2019 22:45:43 -0700
Andrii Nakryiko <andriin@...com> wrote:

> bpf_helpers.h and bpf_endian.h contain useful macros and BPF helper
> definitions essential to almost every BPF program. Which makes them
> useful not just for selftests. To be able to expose them as part of
> libbpf, though, we need them to be dual-licensed as LGPL-2.1 OR
> BSD-2-Clause. This patch updates licensing of those two files.

I've already ACKed this, and is fine with (LGPL-2.1 OR BSD-2-Clause).

I just want to understand, why "BSD-2-Clause" and not "Apache-2.0" ?

The original argument was that this needed to be compatible with
"Apache-2.0", then why not simply add this in the "OR" ?

> Acked-by: Alexei Starovoitov <ast@...nel.org>
> Acked-by: Hechao Li <hechaol@...com>
> Acked-by: Martin KaFai Lau <kafai@...com>
> Acked-by: Andrey Ignatov <rdna@...com>
> Acked-by: Yonghong Song <yhs@...com>
> Acked-by: Lawrence Brakmo <brakmo@...com>
> Acked-by: Adam Barth <arb@...com>
> Acked-by: Roman Gushchin <guro@...com>
> Acked-by: Josef Bacik <jbacik@...com>
> Acked-by: Joe Stringer <joe@...d.net.nz>
> Acked-by: Daniel Borkmann <daniel@...earbox.net>
> Acked-by: Joel Fernandes (Google) <joel@...lfernandes.org>
> Acked-by: David Ahern <dsahern@...il.com>
> Acked-by: Jesper Dangaard Brouer <brouer@...hat.com>

Confirming I acked this.

> Acked-by: Ilya Leoshkevich <iii@...ux.ibm.com>
> Acked-by: Lorenz Bauer <lmb@...udflare.com>
> Acked-by: Adrian Ratiu <adrian.ratiu@...labora.com>
> Acked-by: Nikita V. Shirokov <tehnerd@...nerd.com>
> Acked-by: Willem de Bruijn <willemb@...gle.com>
> Acked-by: Petar Penkov <ppenkov@...gle.com>
> Acked-by: Teng Qin <palmtenor@...il.com>
> Cc: Michael Holzheu <holzheu@...ux.vnet.ibm.com>
> Cc: Naveen N. Rao <naveen.n.rao@...ux.vnet.ibm.com>
> Cc: David S. Miller <davem@...emloft.net>
> Cc: Michal Rostecki <mrostecki@...nsuse.org>
> Cc: John Fastabend <john.fastabend@...il.com>
> Cc: Sargun Dhillon <sargun@...gun.me>
> Signed-off-by: Andrii Nakryiko <andriin@...com>
> ---
>  tools/testing/selftests/bpf/bpf_endian.h  | 2 +-
>  tools/testing/selftests/bpf/bpf_helpers.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/bpf/bpf_endian.h b/tools/testing/selftests/bpf/bpf_endian.h
> index 05f036df8a4c..ff3593b0ae03 100644
> --- a/tools/testing/selftests/bpf/bpf_endian.h
> +++ b/tools/testing/selftests/bpf/bpf_endian.h
> @@ -1,4 +1,4 @@
> -/* SPDX-License-Identifier: GPL-2.0 */
> +/* SPDX-License-Identifier: (LGPL-2.1 OR BSD-2-Clause) */
>  #ifndef __BPF_ENDIAN__
>  #define __BPF_ENDIAN__
>  
> diff --git a/tools/testing/selftests/bpf/bpf_helpers.h b/tools/testing/selftests/bpf/bpf_helpers.h
> index 8b503ea142f0..6c4930bc6e2e 100644
> --- a/tools/testing/selftests/bpf/bpf_helpers.h
> +++ b/tools/testing/selftests/bpf/bpf_helpers.h
> @@ -1,4 +1,4 @@
> -/* SPDX-License-Identifier: GPL-2.0 */
> +/* SPDX-License-Identifier: (LGPL-2.1 OR BSD-2-Clause) */
>  #ifndef __BPF_HELPERS_H
>  #define __BPF_HELPERS_H
>  



-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer