netdev - Re: [PATCH net-next v2 3/3] net: dsa: mt7530: Add support for port 5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190825124813.Horde.ipTYml4Y_iJUAXHsR1A0--K@www.vdorst.com>
Date:   Sun, 25 Aug 2019 12:48:13 +0000
From:   René van Dorst <opensource@...rst.com>
To:     David Miller <davem@...emloft.net>
Cc:     sean.wang@...iatek.com, andrew@...n.ch, vivien.didelot@...il.com,
        f.fainelli@...il.com, matthias.bgg@...il.com,
        netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, john@...ozen.org,
        linux-mips@...r.kernel.org, frank-w@...lic-files.de
Subject: Re: [PATCH net-next v2 3/3] net: dsa: mt7530: Add support for port
 5

Hi David,

Quoting David Miller <davem@...emloft.net>:

> From: René van Dorst <opensource@...rst.com>
> Date: Wed, 21 Aug 2019 16:45:47 +0200
>
>> +	dev_info(ds->dev, "Setup P5, HWTRAP=0x%x, intf_sel=%s, phy-mode=%s\n",
>> +		 val, p5_intf_modes(priv->p5_intf_sel), phy_modes(interface));
>
> This is debugging, at best.  Please make this a debugging message or
> remove it entirely.

I change it to a debug message.

If there is nothing else I send a new version with this change also
add the tags ack-by Russell King and tested-by Frank Wunderlich.

Greats,

René