netdev - Re: [RFC PATCH net-next] net: phy: force phy suspend when calling phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cc52cde5-b114-3bf8-4c4b-fe81c04080ee@cogentembedded.com>
Date:   Tue, 27 Aug 2019 13:11:45 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Jian Shen <shenjian15@...wei.com>, andrew@...n.ch,
        f.fainelli@...il.com, hkallweit1@...il.com, davem@...emloft.net
Cc:     netdev@...r.kernel.org, forest.zhouchang@...wei.com,
        linuxarm@...wei.com
Subject: Re: [RFC PATCH net-next] net: phy: force phy suspend when calling
 phy_stop

On 27.08.2019 5:47, Jian Shen wrote:

> Some ethernet drivers may call phy_start() and phy_stop() from
> ndo_open and ndo_close() respectively.

    ndo_open() for consistency.

> When network cable is unconnected, and operate like below:
> step 1: ifconfig ethX up -> ndo_open -> phy_start ->start
> autoneg, and phy is no link.
> step 2: ifconfig ethX down -> ndo_close -> phy_stop -> just stop
> phy state machine.
> step 3: plugin the network cable, and autoneg complete, then
> LED for link status will be on.
> step 4: ethtool ethX --> see the result of "Link detected" is no.
> 
> This patch forces phy suspend even phydev->link is off.
> 
> Signed-off-by: Jian Shen <shenjian15@...wei.com>
[...]

MBR, Sergei