netdev - Re: [PATCH net-next] net: dsa: mv88e6xxx: get serdes lane after lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 29 Aug 2019 17:20:37 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     vivien.didelot@...il.com
Cc:     netdev@...r.kernel.org, marek.behun@....cz, f.fainelli@...il.com,
        andrew@...n.ch
Subject: Re: [PATCH net-next] net: dsa: mv88e6xxx: get serdes lane after
 lock

From: Vivien Didelot <vivien.didelot@...il.com>
Date: Wed, 28 Aug 2019 12:26:11 -0400

> This is a follow-up patch for commit 17deaf5cb37a ("net: dsa:
> mv88e6xxx: create serdes_get_lane chip operation").
> 
> The .serdes_get_lane implementations access the CMODE of a port,
> even though it is cached at the moment, it is safer to call them
> after the mutex is locked, not before.
> 
> At the same time, check for an eventual error and return IRQ_DONE,
> instead of blindly ignoring it.
> 
> Signed-off-by: Vivien Didelot <vivien.didelot@...il.com>

Applied.