netdev - Re: [PATCH net-next] net: dsa: mv88e6xxx: keep CMODE writable code private

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190829.172043.156380676005553937.davem@davemloft.net>
Date:   Thu, 29 Aug 2019 17:20:43 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     vivien.didelot@...il.com
Cc:     netdev@...r.kernel.org, marek.behun@....cz, f.fainelli@...il.com,
        andrew@...n.ch
Subject: Re: [PATCH net-next] net: dsa: mv88e6xxx: keep CMODE writable code
 private

From: Vivien Didelot <vivien.didelot@...il.com>
Date: Wed, 28 Aug 2019 12:26:59 -0400

> This is a follow-up patch for commit 7a3007d22e8d ("net: dsa:
> mv88e6xxx: fully support SERDES on Topaz family").
> 
> Since .port_set_cmode is only called from mv88e6xxx_port_setup_mac and
> mv88e6xxx_phylink_mac_config, it is fine to keep this "make writable"
> code private to the mv88e6341_port_set_cmode implementation, instead
> of adding yet another operation to the switch info structure.
> 
> Signed-off-by: Vivien Didelot <vivien.didelot@...il.com>

Applied.