netdev - Re: [iproute2, master 1/2] devlink: Print health reporter's dump time-stamp in a helper function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190829162533.25606191@hermes.lan>
Date:   Thu, 29 Aug 2019 16:25:38 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Aya Levin <ayal@...lanox.com>
Cc:     netdev@...r.kernel.org, Jiri Pirko <jiri@...lanox.com>,
        Moshe Shemesh <moshe@...lanox.com>
Subject: Re: [iproute2, master 1/2] devlink: Print health reporter's dump
 time-stamp in a helper function

On Thu, 22 Aug 2019 14:05:41 +0300
Aya Levin <ayal@...lanox.com> wrote:

> Add pr_out_dump_reporter prefix to the helper function's name and
> encapsulate the print in it.
> 
> Fixes: 2f1242efe9d0 ("devlink: Add devlink health show command")
> Signed-off-by: Aya Levin <ayal@...lanox.com>
> Acked-by: Jiri Pirko <jiri@...lanox.com>


Looks fine, but devlink needs to be converted from doing JSON
printing its own way and use common iproute2 libraries.