netdev - Re: [net-next 01/18] net/mlx5: Add flow steering actions to fs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190902.121012.1434735697208917415.davem@davemloft.net>
Date:   Mon, 02 Sep 2019 12:10:12 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     saeedm@...lanox.com
Cc:     netdev@...r.kernel.org, valex@...lanox.com, erezsh@...lanox.com,
        maorg@...lanox.com, markb@...lanox.com
Subject: Re: [net-next 01/18] net/mlx5: Add flow steering actions to fs_cmd
 shim layer

From: Saeed Mahameed <saeedm@...lanox.com>
Date: Mon, 2 Sep 2019 07:22:52 +0000

> +	maction->flow_action_raw.pkt_reformat =
> +		mlx5_packet_reformat_alloc(dev->mdev, prm_prt, len,
> +					   in, namespace);
> +	if (IS_ERR(maction->flow_action_raw.pkt_reformat))
>  		return ret;

Don't you have to initialize 'ret' to the pointer error here?

This transformation doesn't look correct.