netdev - Re: [net-next 01/18] net/mlx5: Add flow steering actions to fs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8f98e4a3df82d90853ae776fba8e8ece3fdeea3c.camel@mellanox.com>
Date:   Tue, 3 Sep 2019 20:08:21 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     "davem@...emloft.net" <davem@...emloft.net>
CC:     Maor Gottlieb <maorg@...lanox.com>,
        Mark Bloch <markb@...lanox.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Alex Vesker <valex@...lanox.com>,
        Erez Shitrit <erezsh@...lanox.com>
Subject: Re: [net-next 01/18] net/mlx5: Add flow steering actions to fs_cmd
 shim layer

On Mon, 2019-09-02 at 12:10 -0700, David Miller wrote:
> From: Saeed Mahameed <saeedm@...lanox.com>
> Date: Mon, 2 Sep 2019 07:22:52 +0000
> 
> > +     maction->flow_action_raw.pkt_reformat =
> > +             mlx5_packet_reformat_alloc(dev->mdev, prm_prt, len,
> > +                                        in, namespace);
> > +     if (IS_ERR(maction->flow_action_raw.pkt_reformat))
> >               return ret;
> 
> Don't you have to initialize 'ret' to the pointer error here?
> 
> This transformation doesn't look correct.

Right! fixed in V2.

Thanks!