lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 3 Sep 2019 08:42:44 +0200 From: Paul Menzel <pmenzel@...gen.mpg.de> To: Stefan Assmann <sassmann@...nic.de>, intel-wired-lan@...ts.osuosl.org Cc: netdev@...r.kernel.org, davem@...emloft.net Subject: Re: [Intel-wired-lan] [PATCH] i40e: clear __I40E_VIRTCHNL_OP_PENDING on invalid min tx rate Dear Stefan, On 03.09.19 08:08, Stefan Assmann wrote: > In the case of an invalid min tx rate being requested > i40e_ndo_set_vf_bw() immediately returns -EINVAL instead of releasing > __I40E_VIRTCHNL_OP_PENDING first. What problem does this cause? > Signed-off-by: Stefan Assmann <sassmann@...nic.de> > --- > drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c > index f8aa4deceb5e..3d2440838822 100644 > --- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c > +++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c > @@ -4263,7 +4263,8 @@ int i40e_ndo_set_vf_bw(struct net_device *netdev, int vf_id, int min_tx_rate, > if (min_tx_rate) { > dev_err(&pf->pdev->dev, "Invalid min tx rate (%d) (greater than 0) specified for VF %d.\n", > min_tx_rate, vf_id); > - return -EINVAL; > + ret = -EINVAL; > + goto error; > } > > vf = &pf->vf[vf_id]; Kind regards, Paul
Powered by blists - more mailing lists