netdev - Re: [PATCH] kcm: use BPF_PROG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0f77cc31-4df5-a74f-5b64-a1e3fc439c6d@fb.com>
Date:   Fri, 6 Sep 2019 00:07:39 +0000
From:   Yonghong Song <yhs@...com>
To:     Sami Tolvanen <samitolvanen@...gle.com>,
        "David S. Miller" <davem@...emloft.net>,
        Tom Herbert <tom@...bertland.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kcm: use BPF_PROG_RUN



On 9/5/19 2:15 PM, Sami Tolvanen wrote:
> Instead of invoking struct bpf_prog::bpf_func directly, use the
> BPF_PROG_RUN macro.
> 
> Signed-off-by: Sami Tolvanen <samitolvanen@...gle.com>

Acked-by: Yonghong Song <yhs@...com>

> ---
>   net/kcm/kcmsock.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/kcm/kcmsock.c b/net/kcm/kcmsock.c
> index 5dbc0c48f8cb..f350c613bd7d 100644
> --- a/net/kcm/kcmsock.c
> +++ b/net/kcm/kcmsock.c
> @@ -379,7 +379,7 @@ static int kcm_parse_func_strparser(struct strparser *strp, struct sk_buff *skb)
>   	struct kcm_psock *psock = container_of(strp, struct kcm_psock, strp);
>   	struct bpf_prog *prog = psock->bpf_prog;
>   
> -	return (*prog->bpf_func)(skb, prog->insnsi);
> +	return BPF_PROG_RUN(prog, skb);
>   }
>   
>   static int kcm_read_sock_done(struct strparser *strp, int err)
>