netdev - Re: [net-next 11/14] ixgbe: Prevent u8 wrapping of ITR value to something less than 10us

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <91551885b0731a9e6121a3afe2c9a6cc912f61d5.camel@linux.intel.com>
Date:   Tue, 10 Sep 2019 15:19:13 -0700
From:   Alexander Duyck <alexander.h.duyck@...ux.intel.com>
To:     Jeff Kirsher <jeffrey.t.kirsher@...el.com>, davem@...emloft.net
Cc:     netdev@...r.kernel.org, nhorman@...hat.com, sassmann@...hat.com,
        Gregg Leventhal <gleventhal@...estreet.com>,
        Andrew Bowers <andrewx.bowers@...el.com>
Subject: Re: [net-next 11/14] ixgbe: Prevent u8 wrapping of ITR value to
 something less than 10us

On Tue, 2019-09-10 at 09:34 -0700, Jeff Kirsher wrote:
> From: Alexander Duyck <alexander.h.duyck@...ux.intel.com>
> 
> There were a couple cases where the ITR value generated via the adaptive
> ITR scheme could exceed 126. This resulted in the value becoming either 0
> or something less than 10. Switching back and forth between a value less
> than 10 and a value greater than 10 can cause issues as certain hardware
> features such as RSC to not function well when the ITR value has dropped
> that low.

One quick thing we can add on here is:
Fixes: b4ded8327fea ("ixgbe: Update adaptive ITR algorithm")

This is likely something that we may want to backport to stable.

> Reported-by: Gregg Leventhal <gleventhal@...estreet.com>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@...ux.intel.com>
> Tested-by: Andrew Bowers <andrewx.bowers@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> index dc034f4e8cf6..a5398b691aa8 100644
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> @@ -2623,7 +2623,7 @@ static void ixgbe_update_itr(struct ixgbe_q_vector *q_vector,
>  		/* 16K ints/sec to 9.2K ints/sec */
>  		avg_wire_size *= 15;
>  		avg_wire_size += 11452;
> -	} else if (avg_wire_size <= 1980) {
> +	} else if (avg_wire_size < 1968) {
>  		/* 9.2K ints/sec to 8K ints/sec */
>  		avg_wire_size *= 5;
>  		avg_wire_size += 22420;
> @@ -2656,6 +2656,8 @@ static void ixgbe_update_itr(struct ixgbe_q_vector *q_vector,
>  	case IXGBE_LINK_SPEED_2_5GB_FULL:
>  	case IXGBE_LINK_SPEED_1GB_FULL:
>  	case IXGBE_LINK_SPEED_10_FULL:
> +		if (avg_wire_size > 8064)
> +			avg_wire_size = 8064;
>  		itr += DIV_ROUND_UP(avg_wire_size,
>  				    IXGBE_ITR_ADAPTIVE_MIN_INC * 64) *
>  		       IXGBE_ITR_ADAPTIVE_MIN_INC;