netdev - Re: [net-next 11/14] ixgbe: Prevent u8 wrapping of ITR value to something less than 10us

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190911.102402.1190991958573233070.davem@davemloft.net>
Date:   Wed, 11 Sep 2019 10:24:02 +0200 (CEST)
From:   David Miller <davem@...emloft.net>
To:     jeffrey.t.kirsher@...el.com
Cc:     alexander.h.duyck@...ux.intel.com, netdev@...r.kernel.org,
        nhorman@...hat.com, sassmann@...hat.com, gleventhal@...estreet.com,
        andrewx.bowers@...el.com
Subject: Re: [net-next 11/14] ixgbe: Prevent u8 wrapping of ITR value to
 something less than 10us

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Tue, 10 Sep 2019 09:34:31 -0700

> From: Alexander Duyck <alexander.h.duyck@...ux.intel.com>
> 
> There were a couple cases where the ITR value generated via the adaptive
> ITR scheme could exceed 126. This resulted in the value becoming either 0
> or something less than 10. Switching back and forth between a value less
> than 10 and a value greater than 10 can cause issues as certain hardware
> features such as RSC to not function well when the ITR value has dropped
> that low.
> 
> Reported-by: Gregg Leventhal <gleventhal@...estreet.com>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@...ux.intel.com>
> Tested-by: Andrew Bowers <andrewx.bowers@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

Please remove this from the series, add the Fixes: tag, and submit for 'net'
since Alexander says it is -stable material.

Thanks.