netdev - Re: [Patch net v2] net_sched: let qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190912203029.GA2330@nanopsycho>
Date:   Thu, 12 Sep 2019 22:30:29 +0200
From:   Jiri Pirko <jiri@...nulli.us>
To:     Cong Wang <xiyou.wangcong@...il.com>
Cc:     netdev@...r.kernel.org,
        syzbot+d5870a903591faaca4ae@...kaller.appspotmail.com,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Jamal Hadi Salim <jhs@...atatu.com>
Subject: Re: [Patch net v2] net_sched: let qdisc_put() accept NULL pointer

Thu, Sep 12, 2019 at 07:22:30PM CEST, xiyou.wangcong@...il.com wrote:
>When tcf_block_get() fails in sfb_init(), q->qdisc is still a NULL
>pointer which leads to a crash in sfb_destroy(). Similar for
>sch_dsmark.
>
>Instead of fixing each separately, Linus suggested to just accept
>NULL pointer in qdisc_put(), which would make callers easier.
>
>(For sch_dsmark, the bug probably exists long before commit
>6529eaba33f0.)
>
>Fixes: 6529eaba33f0 ("net: sched: introduce tcf block infractructure")
>Reported-by: syzbot+d5870a903591faaca4ae@...kaller.appspotmail.com
>Suggested-by: Linus Torvalds <torvalds@...ux-foundation.org>
>Cc: Jamal Hadi Salim <jhs@...atatu.com>
>Cc: Jiri Pirko <jiri@...nulli.us>
>Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>

Acked-by: Jiri Pirko <jiri@...lanox.com>

Thanks!