netdev - Re: [Patch net v2] net_sched: let qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190915.195508.57263100187589453.davem@davemloft.net>
Date:   Sun, 15 Sep 2019 19:55:08 +0100 (WEST)
From:   David Miller <davem@...emloft.net>
To:     xiyou.wangcong@...il.com
Cc:     netdev@...r.kernel.org,
        syzbot+d5870a903591faaca4ae@...kaller.appspotmail.com,
        torvalds@...ux-foundation.org, jhs@...atatu.com, jiri@...nulli.us
Subject: Re: [Patch net v2] net_sched: let qdisc_put() accept NULL pointer

From: Cong Wang <xiyou.wangcong@...il.com>
Date: Thu, 12 Sep 2019 10:22:30 -0700

> When tcf_block_get() fails in sfb_init(), q->qdisc is still a NULL
> pointer which leads to a crash in sfb_destroy(). Similar for
> sch_dsmark.
> 
> Instead of fixing each separately, Linus suggested to just accept
> NULL pointer in qdisc_put(), which would make callers easier.
> 
> (For sch_dsmark, the bug probably exists long before commit
> 6529eaba33f0.)
> 
> Fixes: 6529eaba33f0 ("net: sched: introduce tcf block infractructure")
> Reported-by: syzbot+d5870a903591faaca4ae@...kaller.appspotmail.com
> Suggested-by: Linus Torvalds <torvalds@...ux-foundation.org>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>

Applied and queued up for -stable, thanks.