netdev - Re: [PATCH v5 2/2] tcp: Add snd_wnd to TCP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACSApvZW3ANwJEpzsY4bxMD1ROiK95j3B-GBkC6T60egvXrHSw@mail.gmail.com>
Date:   Sat, 14 Sep 2019 13:57:26 -0400
From:   Soheil Hassas Yeganeh <soheil@...gle.com>
To:     Neal Cardwell <ncardwell@...gle.com>
Cc:     Thomas Higdon <tph@...com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Jonathan Lemon <jonathan.lemon@...il.com>,
        Dave Jones <dsj@...com>, Eric Dumazet <edumazet@...gle.com>,
        Dave Taht <dave.taht@...il.com>,
        Yuchung Cheng <ycheng@...gle.com>
Subject: Re: [PATCH v5 2/2] tcp: Add snd_wnd to TCP_INFO

On Sat, Sep 14, 2019 at 11:45 AM Neal Cardwell <ncardwell@...gle.com> wrote:
>
> On Fri, Sep 13, 2019 at 7:23 PM Thomas Higdon <tph@...com> wrote:
> >
> > Neal Cardwell mentioned that snd_wnd would be useful for diagnosing TCP
> > performance problems --
> > > (1) Usually when we're diagnosing TCP performance problems, we do so
> > > from the sender, since the sender makes most of the
> > > performance-critical decisions (cwnd, pacing, TSO size, TSQ, etc).
> > > From the sender-side the thing that would be most useful is to see
> > > tp->snd_wnd, the receive window that the receiver has advertised to
> > > the sender.
> >
> > This serves the purpose of adding an additional __u32 to avoid the
> > would-be hole caused by the addition of the tcpi_rcvi_ooopack field.
> >
> > Signed-off-by: Thomas Higdon <tph@...com>
> > ---
> > changes since v4:
> >  - clarify comment
>
> Acked-by: Neal Cardwell <ncardwell@...gle.com>

Acked-by: Soheil Hassas Yeganeh <soheil@...gle.com>

Thank you for adding the new field!