netdev - Re: [PATCH v5 1/2] tcp: Add TCP_INFO counter for packets received out-of-order

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190916.163932.682237439904998758.davem@davemloft.net>
Date:   Mon, 16 Sep 2019 16:39:32 +0200 (CEST)
From:   David Miller <davem@...emloft.net>
To:     tph@...com
Cc:     netdev@...r.kernel.org, jonathan.lemon@...il.com, dsj@...com,
        edumazet@...gle.com, ncardwell@...gle.com, dave.taht@...il.com,
        ycheng@...gle.com, soheil@...gle.com
Subject: Re: [PATCH v5 1/2] tcp: Add TCP_INFO counter for packets received
 out-of-order

From: Thomas Higdon <tph@...com>
Date: Fri, 13 Sep 2019 23:23:34 +0000

> For receive-heavy cases on the server-side, we want to track the
> connection quality for individual client IPs. This counter, similar to
> the existing system-wide TCPOFOQueue counter in /proc/net/netstat,
> tracks out-of-order packet reception. By providing this counter in
> TCP_INFO, it will allow understanding to what degree receive-heavy
> sockets are experiencing out-of-order delivery and packet drops
> indicating congestion.
> 
> Please note that this is similar to the counter in NetBSD TCP_INFO, and
> has the same name.
> 
> Also note that we avoid increasing the size of the tcp_sock struct by
> taking advantage of a hole.
> 
> Signed-off-by: Thomas Higdon <tph@...com>

Applied.