netdev - Re: [PATCH v5 2/2] tcp: Add snd_wnd to TCP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190916.163955.2206355736506010205.davem@davemloft.net>
Date:   Mon, 16 Sep 2019 16:39:55 +0200 (CEST)
From:   David Miller <davem@...emloft.net>
To:     tph@...com
Cc:     netdev@...r.kernel.org, jonathan.lemon@...il.com, dsj@...com,
        edumazet@...gle.com, ncardwell@...gle.com, dave.taht@...il.com,
        ycheng@...gle.com, soheil@...gle.com
Subject: Re: [PATCH v5 2/2] tcp: Add snd_wnd to TCP_INFO

From: Thomas Higdon <tph@...com>
Date: Fri, 13 Sep 2019 23:23:35 +0000

> Neal Cardwell mentioned that snd_wnd would be useful for diagnosing TCP
> performance problems --
>> (1) Usually when we're diagnosing TCP performance problems, we do so
>> from the sender, since the sender makes most of the
>> performance-critical decisions (cwnd, pacing, TSO size, TSQ, etc).
>> From the sender-side the thing that would be most useful is to see
>> tp->snd_wnd, the receive window that the receiver has advertised to
>> the sender.
> 
> This serves the purpose of adding an additional __u32 to avoid the
> would-be hole caused by the addition of the tcpi_rcvi_ooopack field.
> 
> Signed-off-by: Thomas Higdon <tph@...com>

Applied.