netdev - Re: [PATCH V1 net-next 2/5] net: ena: multiple queue creation related cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190916.214438.647698482843698023.davem@davemloft.net>
Date:   Mon, 16 Sep 2019 21:44:38 +0200 (CEST)
From:   David Miller <davem@...emloft.net>
To:     sameehj@...zon.com
Cc:     netdev@...r.kernel.org, dwmw@...zon.com, zorik@...zon.com,
        matua@...zon.com, saeedb@...zon.com, msw@...zon.com,
        aliguori@...zon.com, nafea@...zon.com, gtzalik@...zon.com,
        netanel@...zon.com, alisaidi@...zon.com, benh@...zon.com,
        akiyano@...zon.com
Subject: Re: [PATCH V1 net-next 2/5] net: ena: multiple queue creation
 related cleanups

From: <sameehj@...zon.com>
Date: Sun, 15 Sep 2019 18:27:19 +0300

> @@ -1885,6 +1885,13 @@ static int ena_up(struct ena_adapter *adapter)
>  	if (rc)
>  		goto err_req_irq;
>  
> +	netif_info(adapter, ifup, adapter->netdev, "creating %d io queues. rx queue size: %d tx queue size. %d LLQ is %s\n",
> +		   adapter->num_io_queues,
> +		   adapter->requested_rx_ring_size,
> +		   adapter->requested_tx_ring_size,
> +		   (adapter->ena_dev->tx_mem_queue_type == ENA_ADMIN_PLACEMENT_POLICY_DEV) ?
> +		   "ENABLED" : "DISABLED");

Please don't clog up the kernel log with stuff like this.

Maybe netif_debug() at best, but I'd rather you remove this entirely.  It's so
easy to make a device go up and down repeatedly multiple times in one second.