netdev - RE: [PATCH V1 net-next 2/5] net: ena: multiple queue creation related cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ffbbb841d147426bb76a6c4e77d4c1f9@EX13D11EUB003.ant.amazon.com>
Date:   Thu, 19 Sep 2019 14:05:32 +0000
From:   "Jubran, Samih" <sameehj@...zon.com>
To:     David Miller <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Woodhouse, David" <dwmw@...zon.co.uk>,
        "Machulsky, Zorik" <zorik@...zon.com>,
        "Matushevsky, Alexander" <matua@...zon.com>,
        "Bshara, Saeed" <saeedb@...zon.com>,
        "Wilson, Matt" <msw@...zon.com>,
        "Liguori, Anthony" <aliguori@...zon.com>,
        "Bshara, Nafea" <nafea@...zon.com>,
        "Tzalik, Guy" <gtzalik@...zon.com>,
        "Belgazal, Netanel" <netanel@...zon.com>,
        "Saidi, Ali" <alisaidi@...zon.com>,
        "Herrenschmidt, Benjamin" <benh@...zon.com>,
        "Kiyanovski, Arthur" <akiyano@...zon.com>
Subject: RE: [PATCH V1 net-next 2/5] net: ena: multiple queue creation related
 cleanups



> -----Original Message-----
> From: David Miller <davem@...emloft.net>
> Sent: Monday, September 16, 2019 10:45 PM
> To: Jubran, Samih <sameehj@...zon.com>
> Cc: netdev@...r.kernel.org; Woodhouse, David <dwmw@...zon.co.uk>;
> Machulsky, Zorik <zorik@...zon.com>; Matushevsky, Alexander
> <matua@...zon.com>; Bshara, Saeed <saeedb@...zon.com>; Wilson,
> Matt <msw@...zon.com>; Liguori, Anthony <aliguori@...zon.com>;
> Bshara, Nafea <nafea@...zon.com>; Tzalik, Guy <gtzalik@...zon.com>;
> Belgazal, Netanel <netanel@...zon.com>; Saidi, Ali
> <alisaidi@...zon.com>; Herrenschmidt, Benjamin <benh@...zon.com>;
> Kiyanovski, Arthur <akiyano@...zon.com>
> Subject: Re: [PATCH V1 net-next 2/5] net: ena: multiple queue creation
> related cleanups
> 
> From: <sameehj@...zon.com>
> Date: Sun, 15 Sep 2019 18:27:19 +0300
> 
> > @@ -1885,6 +1885,13 @@ static int ena_up(struct ena_adapter *adapter)
> >  	if (rc)
> >  		goto err_req_irq;
> >
> > +	netif_info(adapter, ifup, adapter->netdev, "creating %d io queues.
> rx queue size: %d tx queue size. %d LLQ is %s\n",
> > +		   adapter->num_io_queues,
> > +		   adapter->requested_rx_ring_size,
> > +		   adapter->requested_tx_ring_size,
> > +		   (adapter->ena_dev->tx_mem_queue_type ==
> ENA_ADMIN_PLACEMENT_POLICY_DEV) ?
> > +		   "ENABLED" : "DISABLED");
> 
> Please don't clog up the kernel log with stuff like this.
> 
> Maybe netif_debug() at best, but I'd rather you remove this entirely.  It's so
> easy to make a device go up and down repeatedly multiple times in one
> second.
Dropped in v2.