lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 17 Sep 2019 11:07:57 +0800 From: zhong jiang <zhongjiang@...wei.com> To: Jakub Kicinski <jakub.kicinski@...ronome.com> CC: <davem@...emloft.net>, <kvalo@...eaurora.org>, <pkshih@...ltek.com>, <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 2/3] nfp: Drop unnecessary continue in nfp_net_pf_alloc_vnics On 2019/9/17 10:45, Jakub Kicinski wrote: > On Wed, 4 Sep 2019 11:46:23 +0800, zhong jiang wrote: >> Continue is not needed at the bottom of a loop. >> >> Signed-off-by: zhong jiang <zhongjiang@...wei.com> >> --- >> drivers/net/ethernet/netronome/nfp/nfp_net_main.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_main.c b/drivers/net/ethernet/netronome/nfp/nfp_net_main.c >> index 986464d..68db47d 100644 >> --- a/drivers/net/ethernet/netronome/nfp/nfp_net_main.c >> +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_main.c >> @@ -205,10 +205,8 @@ static void nfp_net_pf_free_vnics(struct nfp_pf *pf) >> ctrl_bar += NFP_PF_CSR_SLICE_SIZE; >> >> /* Kill the vNIC if app init marked it as invalid */ >> - if (nn->port && nn->port->type == NFP_PORT_INVALID) { >> + if (nn->port && nn->port->type == NFP_PORT_INVALID) >> nfp_net_pf_free_vnic(pf, nn); >> - continue; >> - } > Ugh, I already nack at least one patch like this, this continue makes > the _intent_ of the code more clear, the compiler will ignore it anyway. Thanks, I miss that information you object to above modification. Sincerely, zhong jiang > I guess there's no use in fighting the bots.. > >> } >> >> if (list_empty(&pf->vnics)) > > . >
Powered by blists - more mailing lists