netdev - [PATCH net-next] ixgbe: Use memzero_explicit directly in crypto cases

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1568774195-8677-1-git-send-email-zhongjiang@huawei.com>
Date:   Wed, 18 Sep 2019 10:36:35 +0800
From:   zhong jiang <zhongjiang@...wei.com>
To:     <jakub.kicinski@...ronome.com>, <davem@...emloft.net>
CC:     <anna.schumaker@...app.com>, <trond.myklebust@...merspace.com>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <zhongjiang@...wei.com>
Subject: [PATCH net-next] ixgbe: Use memzero_explicit directly in crypto cases

In general, Use kzfree() to replace memset() + kfree() is feasible and
resonable.  But It's btter to use memzero_explicit() to replace memset()
in crypto cases.

Signed-off-by: zhong jiang <zhongjiang@...wei.com>
---
 drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c
index 113f608..7e4f32f 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c
@@ -960,9 +960,11 @@ int ixgbe_ipsec_vf_add_sa(struct ixgbe_adapter *adapter, u32 *msgbuf, u32 vf)
 	return 0;
 
 err_aead:
-	kzfree(xs->aead);
+	memzero_explicit(xs->aead, sizeof(*xs->aead));
+	kfree(xs->aead);
 err_xs:
-	kzfree(xs);
+	memzero_explicit(xs, sizeof(*xs));
+	kfree(xs);
 err_out:
 	msgbuf[1] = err;
 	return err;
@@ -1047,7 +1049,8 @@ int ixgbe_ipsec_vf_del_sa(struct ixgbe_adapter *adapter, u32 *msgbuf, u32 vf)
 	ixgbe_ipsec_del_sa(xs);
 
 	/* remove the xs that was made-up in the add request */
-	kzfree(xs);
+	memzero_explicit(xs, sizeof(*xs));
+	kfree(xs);
 
 	return 0;
 }
-- 
1.7.12.4