lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 23 Sep 2019 12:00:41 -0400 From: "Michael S. Tsirkin" <mst@...hat.com> To: Alex Williamson <alex.williamson@...hat.com> Cc: Jason Wang <jasowang@...hat.com>, kvm@...r.kernel.org, linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org, intel-gfx@...ts.freedesktop.org, intel-gvt-dev@...ts.freedesktop.org, kwankhede@...dia.com, tiwei.bie@...el.com, virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org, cohuck@...hat.com, maxime.coquelin@...hat.com, cunming.liang@...el.com, zhihong.wang@...el.com, rob.miller@...adcom.com, xiao.w.wang@...el.com, haotian.wang@...ive.com, zhenyuw@...ux.intel.com, zhi.a.wang@...el.com, jani.nikula@...ux.intel.com, joonas.lahtinen@...ux.intel.com, rodrigo.vivi@...el.com, airlied@...ux.ie, daniel@...ll.ch, farman@...ux.ibm.com, pasic@...ux.ibm.com, sebott@...ux.ibm.com, oberpar@...ux.ibm.com, heiko.carstens@...ibm.com, gor@...ux.ibm.com, borntraeger@...ibm.com, akrowiak@...ux.ibm.com, freude@...ux.ibm.com, lingshan.zhu@...el.com, idos@...lanox.com, eperezma@...hat.com, lulu@...hat.com, parav@...lanox.com Subject: Re: [PATCH 5/6] vringh: fix copy direction of vringh_iov_push_kern() On Mon, Sep 23, 2019 at 09:45:59AM -0600, Alex Williamson wrote: > On Mon, 23 Sep 2019 21:03:30 +0800 > Jason Wang <jasowang@...hat.com> wrote: > > > We want to copy from iov to buf, so the direction was wrong. > > > > Signed-off-by: Jason Wang <jasowang@...hat.com> > > --- > > drivers/vhost/vringh.c | 8 +++++++- > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > Why is this included in the series? Seems like an unrelated fix being > held up within a proposal for a new feature. Thanks, > > Alex It's better to have it as patch 1/6, but it's a dependency of the example driver in the series. I can reorder when I apply. > > diff --git a/drivers/vhost/vringh.c b/drivers/vhost/vringh.c > > index 08ad0d1f0476..a0a2d74967ef 100644 > > --- a/drivers/vhost/vringh.c > > +++ b/drivers/vhost/vringh.c > > @@ -852,6 +852,12 @@ static inline int xfer_kern(void *src, void *dst, size_t len) > > return 0; > > } > > > > +static inline int kern_xfer(void *dst, void *src, size_t len) > > +{ > > + memcpy(dst, src, len); > > + return 0; > > +} > > + > > /** > > * vringh_init_kern - initialize a vringh for a kernelspace vring. > > * @vrh: the vringh to initialize. > > @@ -958,7 +964,7 @@ EXPORT_SYMBOL(vringh_iov_pull_kern); > > ssize_t vringh_iov_push_kern(struct vringh_kiov *wiov, > > const void *src, size_t len) > > { > > - return vringh_iov_xfer(wiov, (void *)src, len, xfer_kern); > > + return vringh_iov_xfer(wiov, (void *)src, len, kern_xfer); > > } > > EXPORT_SYMBOL(vringh_iov_push_kern); > >
Powered by blists - more mailing lists