netdev - Re: [PATCH v2 net] sk_buff: drop all skb extensions on free and skb scrubbing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fce20607-baa3-eecf-6330-08a66d9097dc@gmail.com>
Date:   Thu, 26 Sep 2019 12:16:14 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Florian Westphal <fw@...len.de>,
        Eric Dumazet <eric.dumazet@...il.com>
Cc:     netdev@...r.kernel.org, steffen.klassert@...unet.com,
        paulb@...lanox.com, vladbu@...lanox.com
Subject: Re: [PATCH v2 net] sk_buff: drop all skb extensions on free and skb
 scrubbing



On 9/26/19 12:09 PM, Florian Westphal wrote:
> Eric Dumazet <eric.dumazet@...il.com> wrote:
>>> -	secpath_reset(skb);
>>> +	skb_ext_reset(skb);
>>>  	nf_reset(skb);
>>>  	nf_reset_trace(skb);
>>
>>
>> It is unfortunate nf_reset(skb) will call skb_ext_del(skb, SKB_EXT_BRIDGE_NF),
>> which is useless after skb_ext_reset(skb) 
>>
>> Maybe time for a nf_ct_reset() helper only dealing with nfct.
> 
> Agree, but that seems more like -next material?

Sure.