netdev - Re: [PATCH v2 net] sk_buff: drop all skb extensions on free and skb scrubbing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190927.204059.1317123662569262129.davem@davemloft.net>
Date:   Fri, 27 Sep 2019 20:40:59 +0200 (CEST)
From:   David Miller <davem@...emloft.net>
To:     fw@...len.de
Cc:     netdev@...r.kernel.org, steffen.klassert@...unet.com,
        paulb@...lanox.com, vladbu@...lanox.com
Subject: Re: [PATCH v2 net] sk_buff: drop all skb extensions on free and
 skb scrubbing

From: Florian Westphal <fw@...len.de>
Date: Thu, 26 Sep 2019 20:37:05 +0200

> Now that we have a 3rd extension, add a new helper that drops the
> extension space and use it when we need to scrub an sk_buff.
> 
> At this time, scrubbing clears secpath and bridge netfilter data, but
> retains the tc skb extension, after this patch all three get cleared.
> 
> NAPI reuse/free assumes we can only have a secpath attached to skb, but
> it seems better to clear all extensions there as well.
> 
> v2: add unlikely hint (Eric Dumazet)
> 
> Fixes: 95a7233c452a ("net: openvswitch: Set OvS recirc_id from tc chain index")
> Signed-off-by: Florian Westphal <fw@...len.de>

Applied.