netdev - Re: [PATCH v2 net] net: sched: fix possible crash in tcf_action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190926.085936.1117617922335141238.davem@davemloft.net>
Date:   Thu, 26 Sep 2019 08:59:36 +0200 (CEST)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com,
        syzkaller@...glegroups.com, xiyou.wangcong@...il.com,
        vladbu@...lanox.com, jiri@...lanox.com
Subject: Re: [PATCH v2 net] net: sched: fix possible crash in
 tcf_action_destroy()

From: Eric Dumazet <edumazet@...gle.com>
Date: Mon, 23 Sep 2019 15:18:57 -0700

> If the allocation done in tcf_exts_init() failed,
> we end up with a NULL pointer in exts->actions.
 ...
> Fixes: 90b73b77d08e ("net: sched: change action API to use array of pointers to actions")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: syzbot <syzkaller@...glegroups.com>

Eric, I applied v1 yesterday that guards at the call site.

Please send a relative patch if you want to do it this way instead.

Sorry.