netdev - Re: [PATCH] r8152: Use guard clause and fix comment typos

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190926.090032.1228409542844231601.davem@davemloft.net>
Date:   Thu, 26 Sep 2019 09:00:32 +0200 (CEST)
From:   David Miller <davem@...emloft.net>
To:     pmalani@...omium.org
Cc:     hayeswang@...ltek.com, grundler@...omium.org,
        netdev@...r.kernel.org, nic_swsd@...ltek.com
Subject: Re: [PATCH] r8152: Use guard clause and fix comment typos

From: Prashant Malani <pmalani@...omium.org>
Date: Mon, 23 Sep 2019 15:26:57 -0700

> Use a guard clause in tx_bottom() to reduce the indentation of the
> do-while loop. In doing so, convert the do-while to a while to make the
> guard clause checks consistent.
> 
> Also, fix a couple of spelling and grammatical mistakes in the
> r8152_csum_workaround() function comment.
> 
> Change-Id: I460befde150ad92248fd85b0f189ec2df2ab8431
> Signed-off-by: Prashant Malani <pmalani@...omium.org>
> Reviewed-by: Grant Grundler <grundler@...omium.org>

This is only approiate for net-next, so please resubmit this when the
net-next tree opens back up.