netdev - Re: [PATCH net] net: hisilicon: Fix signedness bug in hix5hd2_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190927.100210.239358779936843638.davem@davemloft.net>
Date:   Fri, 27 Sep 2019 10:02:10 +0200 (CEST)
From:   David Miller <davem@...emloft.net>
To:     dan.carpenter@...cle.com
Cc:     yisen.zhuang@...wei.com, zhangfei.gao@...aro.org,
        salil.mehta@...wei.com, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net] net: hisilicon: Fix signedness bug in
 hix5hd2_dev_probe()

From: Dan Carpenter <dan.carpenter@...cle.com>
Date: Wed, 25 Sep 2019 13:55:32 +0300

> The "priv->phy_mode" variable is an enum and in this context GCC will
> treat it as unsigned to the error handling will never trigger.
> 
> Fixes: 57c5bc9ad7d7 ("net: hisilicon: add hix5hd2 mac driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Applied.